Open
Conversation
yurii-litvinov
suggested changes
May 25, 2023
|
|
||
| class Program | ||
| { | ||
| public static void Main() |
| @@ -0,0 +1,19 @@ | |||
| <Project Sdk="Microsoft.NET.Sdk"> | |||
There was a problem hiding this comment.
Все три функции на самом деле должны быть в одном классе, а у Вас аж три отдельных (!) проекта с тестами. Упростите структуру решения, пожалуйста :)
| /// <summary> | ||
| /// Implements the filter function | ||
| /// </summary> | ||
| public class FilterList |
There was a problem hiding this comment.
Тут и ниже не хватает static-ов, потому как у класса нет своего состояния.
| { | ||
| if (list == null) | ||
| { | ||
| return null; |
There was a problem hiding this comment.
А нельзя так. Кидайте исключение
| { | ||
| return null; | ||
| } | ||
| List<TypeOfValue> newList = new List<TypeOfValue>(); |
There was a problem hiding this comment.
Suggested change
| List<TypeOfValue> newList = new List<TypeOfValue>(); | |
| List<TypeOfValue> newList = new(); |
FilterFoldMap/FilterFoldMap/Fold.cs
Outdated
| /// <param name="accumulatedValue">Cumulative value with the selected type</param> | ||
| /// <param name="function">A function for accumulating a value, takes an accumulating value and a list item</param> | ||
| /// <returns>Accumulated value</returns> | ||
| public TypeOfValue Fold<TypeOfValue>(List<TypeOfValue> list, TypeOfValue accumulatedValue, Func<TypeOfValue, TypeOfValue, TypeOfValue> function) |
There was a problem hiding this comment.
Можно более общий тип, потому что тип результата не обязан совпадать с типом значений в списке
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Задача на filter fold map